Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra spooky CSS #1

Closed
wants to merge 3 commits into from
Closed

Extra spooky CSS #1

wants to merge 3 commits into from

Conversation

nickfarrow
Copy link

@nickfarrow nickfarrow commented Oct 25, 2022

Some small CSS additions and spooky background.
Also starting to separate into a Config and Queue Channel forms
image

@nickfarrow
Copy link
Author

Can we hide the option in the first input field?

<datalist id="defaultReserveSats">
	<option value="10000"></option>
</datalist>

Copy link
Owner

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be good to get this PR on the nolooking repo

static/index.html Outdated Show resolved Hide resolved
static/index.html Outdated Show resolved Hide resolved
Copy link
Owner

@DanGould DanGould left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are the images identical?

static/index.html Outdated Show resolved Hide resolved
static/index.html Outdated Show resolved Hide resolved
@nickfarrow
Copy link
Author

The other unused image is more zoomed out -> more spooky pumpkins, might use later (mobile). Lmk if you want me to rebase onto your changes

@DanGould
Copy link
Owner

Can we hide the option in the first input field?


<datalist id="defaultReserveSats">

	<option value="10000"></option>

</datalist>

what do you mean by hide?

@nickfarrow
Copy link
Author

Can we hide the option in the first input field?


<datalist id="defaultReserveSats">

	<option value="10000"></option>

</datalist>

what do you mean by hide?

I originally wanted to somehow default it, but sounds like this has potential Kixunil/loptos#11 . If i understand the desired behavior correctly then maybe it would be possible to hack something together also if channels.len() > 0 {...} else ..., but would need to expose the channels (we will probably want to be able to fetch a list of our channels in the future anyway to display to user and show them channel status!

@DanGould
Copy link
Owner

QR could probably be 1 commit independent of the others. Why use JS instead of the rust lib in satsale? Seems like using the rust to output a svg might make more sense. idk where this js came from

@nickfarrow
Copy link
Author

QR could probably be 1 commit independent of the others. Why use JS instead of the rust lib in satsale? Seems like using the rust to output a svg might make more sense. idk where this js came from

yeah for sure, just wanted to get it working for the mvp and app submission. We should create in rust

@nickfarrow nickfarrow force-pushed the mvp-ui branch 5 times, most recently from 863d9c4 to 48598a3 Compare November 1, 2022 05:18
@DanGould DanGould force-pushed the mvp-ui branch 3 times, most recently from 42610ca to 3fb460d Compare November 1, 2022 20:42
Separate configuration and channel queue forms. Channel queue form
is now fixed so user input is persistent by using "appendChild".

Add a spooky user interface with DALLE background pumpkins. Add emojis and
placeholder form text. Provides link to suggest payjoin wallets..
Use qrcode_generator crate to generate and store QR codes as
`STATIC/qr_codes/<address>.png`. These QR codes are fetched
to display on the frontend using the address from the BIP21 uri.
@DanGould
Copy link
Owner

this was merged upstream

@DanGould DanGould closed this Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants