[WIP] 6.x #405
Merged
[WIP] 6.x #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
oleg-andreyev
commented
Feb 28, 2024
oleg-andreyev
commented
- Master is 6.x for development
- Merge stuff from 5.x to ensure that master is up-to-date
- Using this PR for attempt of upgrade to Symfony 7.x
…arper#350) * DamienHarper#345 Deprecation in RoleChecker and UserProvider * remove line --------- Co-authored-by: a.dmitryuk <[email protected]>
* remove doctrine/annotations from composer.json * doctrine/annotations 2.0 --------- Co-authored-by: a.dmitryuk <[email protected]>
* Fix: `ViewerController` * - * - * - * Fixed remaining calls to AbstractController methods. * - * - * - * - * PHP-CS-Fixer --------- Co-authored-by: Damien Harper <[email protected]>
Co-authored-by: Damien Harper <[email protected]>
Co-authored-by: Damien Harper <[email protected]>
Co-authored-by: Damien Harper <[email protected]>
# Conflicts: # .github/workflows/ci-5.x.yml # composer.json # phpstan.neon # src/Controller/ViewerController.php # tests/App/Command/CreatePostCommand.php # tests/DHAuditorBundleTest.php
Signed-off-by: Oleg Andreyev <[email protected]>
Signed-off-by: Oleg Andreyev <[email protected]>
Signed-off-by: Oleg Andreyev <[email protected]>
Signed-off-by: Oleg Andreyev <[email protected]>
Signed-off-by: Oleg Andreyev <[email protected]>
Signed-off-by: Oleg Andreyev <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=======================================
Coverage 92.47% 92.47%
=======================================
Files 15 15
Lines 359 359
=======================================
Hits 332 332
Misses 27 27 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Oleg Andreyev <[email protected]>
|
Is there are any reason why this not merged? All looks good. |
# Conflicts: # phpstan.neon
DamienHarper
approved these changes
Jul 14, 2024
maxhelias
reviewed
Aug 16, 2024
DamienHarper
added a commit
that referenced
this pull request
Sep 10, 2024
… by error when #405 was merged)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.