symfony/lock required in non-dev

[n3o77]

otherwise audit:clean and audit:schema:update can’t be executed

[DamienHarper]

Could you please update doc accordingly

[maxhelias]

I think the lock should remain in require-dev, but do a check before using the feature to be able to throw an exception to warn the user to add it on dependencies

[n3o77]

@maxhelias i would only agree on keeping it in require-dev if it wasn't required for the first installation steps. As it's now possible again to use default doctrine commands to update the database the docs could be changed to use those. Then we could mention the symfony/lock install when describing multi-db setups or cleaning up old logs.

@DamienHarper how would you like to handle this?

[DamienHarper]

@maxhelias this is already the case and documented in the cleaning section of the documentation (only) as of now.

In order to keep dependencies minimal and given the fact that (AFAIK):

• most users don't clean their audit tables, they don't need the lock component.
• schema update (in an upgrade scenario) is done in dev environment and using migrations most of the time.
• the requirement is always tested at runtime and the exception thrown when the requirement is not satisfied is self explanatory.

So, we don't need to make this dependency a hard requirement => let's keep it in require-dev section of composer.json for now but we need to add a notice about the requirement in the audit table creation section of the documentation.

[n3o77]

@DamienHarper i changed the file so it's supporting ^3.4 || ^4.0 in dev

[maxhelias]

Prevent users with an exception at the beginning of the execution command like this :

if (!class_exists(Lock::class)) {
    throw new LogicException('The Lock component is required to use this command. Try running "composer require symfony/lock".');
}

Is a must have in addition to the documentation

[DamienHarper]

@maxhelias this is already enforced by using the LockableTrait

[maxhelias]

Indeed, I had not seen 👍

[DamienHarper]

@n3o77 we only miss the notice in the doc to merge this PR

[n3o77]

@DamienHarper sorry, i thought you already changed that. I'll update in a few min

[n3o77]

I moved the symfony/lock module to require again and removed the notice that the package needs to be installed.