Unknown "spaceless" filter.

[balvirsingh]

I installed this bundle on Symfony 4.2, the mentioned below issue is occurring.

Unknown "spaceless" filter.

if I remove it from twig file, then works fine.

Please provide the solution or tell me how to override the twig.

[DamienHarper]

@balvirsingh thanks for your feedback, the spaceless tag is deprecated since Twig 1.38 in favor of the spaceless filter. What version of Twig is installed in your application?

[balvirsingh]

symfony/twig-bundle - v4.2.2 Symfony TwigBundle
twig/twig - v2.6.2 Twig, the flexible, fast, and secure template language for PHP

So, it's 2.6.2.

Have you checked your bundle is working on symfony 4.2 ?

[balvirsingh]

Or can I override the template?

One more issue:-
When I call mentioned below method in my controller's function, it gives an error

$reader = $this->container->get('dh_doctrine_audit.reader');

---

Error -

Service "dh_doctrine_audit.reader" not found: even though it exists in the app's container, the container inside "App\Controller\OrganizerController" is a smaller service locator that only knows about the "doctrine", "form.factory", "http_kernel", "parameter_bag", "request_stack", "router", "security.authorization_checker", "security.csrf.token_manager", "security.token_storage", "session" and "twig" services. Try using dependency injection instead.

[balvirsingh]

Hi, I have added some more details about it, Please check these and let me know if issue can be resolved?

…

On Thu, May 23, 2019 at 1:39 AM Damien Harper ***@***.***> wrote: @balvirsingh <https://github.com/balvirsingh> thanks for your feedback, the spaceless tag is deprecated since Twig 1.38 in favor of the spaceless filter. What version of Twig is installed in your application? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#65>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABL4RVTOL7ZO6F5CL3FWCL3PWWSBBANCNFSM4HOULFXQ> .

[DamienHarper]

@balvirsingh That's quite weird. I need some more time to identify/reproduce the issue. Meanwhile, you can override the template and remove the spaceless filter call.

Regarding the reader service, you should be able to inject it in a constructor/method, for example:

public function getHistory(AuditReader $reader, string $entity, string $id, int $page = 1, int $pageSize = 500): Response
{
    // ...
}

Where do you try to access the reader: from a controller? from a command?

[balvirsingh]

Yes, I am trying to access in the controller.

[DamienHarper]

@balvirsingh can you post what your controller inherits from?

[balvirsingh]

`<?php

namespace App\Controller;

use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Routing\Annotation\Route;
use Symfony\Component\HttpFoundation\JsonResponse;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpFoundation\RedirectResponse;
use Symfony\Component\Validator\Validator\ValidatorInterface;
use App\Services\CoreService;
use App\Entity\Organizer;

use Sensio\Bundle\FrameworkExtraBundle\Configuration\Entity;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;

class OrganizerController extends AbstractController
{

/**
 * To find list of organizers
 *
 * @return \Symfony\Component\HttpFoundation\Response
 */
public function list()
{   

    $reader = $this->get('dh_doctrine_audit.reader');
    
    $data = $reader
         ->filterBy(AuditReader::UPDATE)   // add this to only get `update` entries.
         ->getAudit('App\Entity\Organizer', 10)
     ;

    return $this->render('organizer/list.html.twig', [
        'no_sidebar' => true,
        'data' => $data
    ]);
}

}`

[balvirsingh]

I just sent full controller code, pl check.

[DamienHarper]

@balvirsingh your controller extends AbstractController which let you access a "limited" container that's why you cannot access the reader from there. The best solution for you here is to inject the reader service to your OrganizerController::list() method.

public function list(AuditReader $reader)
{
    // ...
}

[balvirsingh]

Hi @DamienHarper,

Great!, it works now on my system. Please work on the spaceless filter. I suggest you to please remove this filter from twig as its deprecated now.

Thank you so much.

[balvirsingh]

Hi @DamienHarper,

Unknown "spaceless" filter.
Have you work

Have you worked on the above issue? Still, I am facing the same issue. I don't want to override the templates. Please remove that filter for me or do any other alternative to make it work.

Thanks.

[DamienHarper]

@balvirsingh I have a job that keeps me very busy lately so I cannot work on this project all the time. Also, I am notified when an issue is opened/commented/closed as well as when a PR is opened/commented/declined/etc. so no need to comment + send an email + send a LinkedIn message, it won't make things happen faster.

Please, test against master branch: spaceless filter is not used anymore but the spaceless tag is. I'll release a new version in the next days.

[balvirsingh]

Hi @DamienHarper,

I sincerely apologize for bothering. I will be careful in future.

Thanks.

[DamienHarper]

@balvirsingh let's forget it and move forward ;)
does the master branch solve your issue?

[balvirsingh]

Hi @DamienHarper,

Yes, it does work now, Thanks

[DamienHarper]

@balvirsingh thanks for the feedback.
I close this issue as the fix will be part of next release.