Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fetch total rows count #79

Merged
merged 3 commits into from
Mar 9, 2024
Merged

fetch total rows count #79

merged 3 commits into from
Mar 9, 2024

Conversation

Abhishek-N
Copy link
Contributor

No description provided.

resultset = self.execute(
f"""
SELECT COUNT(*)
FROM "{schema}"."{table}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't bigquery syntax use backticks... have you tested this

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 19.04762% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 76.16%. Comparing base (09fdf41) to head (71e911d).
Report is 12 commits behind head on main.

Files Patch % Lines
dbt_automation/utils/bigquery.py 16.66% 10 Missing ⚠️
dbt_automation/utils/postgres.py 22.22% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #79      +/-   ##
==========================================
- Coverage   80.70%   76.16%   -4.55%     
==========================================
  Files          23       24       +1     
  Lines        1026     1099      +73     
==========================================
+ Hits          828      837       +9     
- Misses        198      262      +64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit f0e669a into main Mar 9, 2024
1 check passed
@fatchat fatchat deleted the preview-data-for-workflow branch March 9, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants