Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dbt throws error if we have duplicate names #63

Merged
merged 7 commits into from
Feb 17, 2024
Merged

dbt throws error if we have duplicate names #63

merged 7 commits into from
Feb 17, 2024

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented Feb 16, 2024

Because of current logic we had sheet1 and _airbyte_name_sheet1 having same names i.e. sheet1 in sources.yml. For this, dbt threw error.
Looks like name should also be unique like identifier in sources.yml

…airbyte_raw_sheet1 should have different names
@Ishankoradia Ishankoradia changed the title dbt throws error if we have duplicate names; for example sheet1 and _… dbt throws error if we have duplicate names Feb 16, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f1239b1) 78.83% compared to head (dd1e5f9) 78.83%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #63   +/-   ##
=======================================
  Coverage   78.83%   78.83%           
=======================================
  Files          21       21           
  Lines         808      808           
=======================================
  Hits          637      637           
  Misses        171      171           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishankoradia
Copy link
Contributor Author

@fatchat ready to be merged, have fixed the test cases

@fatchat fatchat merged commit 9b932da into main Feb 17, 2024
1 check passed
@fatchat fatchat deleted the minor_change branch February 17, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants