Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

39 test cases for dbt automation #44

Merged
merged 60 commits into from
Nov 6, 2023
Merged

Conversation

fatchat
Copy link
Contributor

@fatchat fatchat commented Oct 29, 2023

No description provided.

@fatchat fatchat linked an issue Oct 29, 2023 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2023

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

@Ishankoradia Ishankoradia marked this pull request as draft November 1, 2023 02:05
@Ishankoradia
Copy link
Contributor

Ishankoradia commented Nov 1, 2023

Have written tests cases for the utility functions except warehousec clients. Code coverage & CI is also setup

Will then write test cases for each operation along with running the dbt code and checking the output at the warehouse.

@fatchat
Copy link
Contributor Author

fatchat commented Nov 6, 2023

check_call when running commands via subprocess

@fatchat
Copy link
Contributor Author

fatchat commented Nov 6, 2023

when you run a command which generates a file (e.g. sources.yml) and you are testing for the existence of the file after, make sure the file doesn't exist beforehand. when this runs on github it won't be there but when we run locally we may have stuff left over from previous runs

@Ishankoradia
Copy link
Contributor

when this runs on github it won't be there

It will not be there for sure. For each test run locally pytest creates a new temp directory (tmpdir fixture that i am using). Everything starts from fresh everytime we run pytest

@Ishankoradia Ishankoradia self-assigned this Nov 6, 2023
…ving this branch from the github workflow (all testcases have passed)
@Ishankoradia Ishankoradia marked this pull request as ready for review November 6, 2023 14:42
@Ishankoradia Ishankoradia self-requested a review November 6, 2023 14:48
Ishankoradia
Ishankoradia previously approved these changes Nov 6, 2023
@fatchat fatchat merged commit d590848 into main Nov 6, 2023
1 check passed
@fatchat fatchat deleted the 39-test-cases-for-dbt-automation branch November 6, 2023 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test cases for dbt automation
3 participants