섹션 컴포넌트 API 리디자인 #198
Merged
섹션 컴포넌트 API 리디자인 #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleSeo
commented
Sep 6, 2024
| <ds-header></ds-header> | ||
|
|
||
| <ds-intro-section id="intro-section"></ds-intro-section> |
There was a problem hiding this comment.
요 ID는 참조하는 곳이 없는 것 같아서 제거했는데 혹시 제가 실수한 거면 알려주세요.
There was a problem hiding this comment.
현재는 사용하는 곳이 없네요! 정리 감사합니다!
| @@ -76,34 +76,34 @@ class LanguageSection extends HTMLElement { | |||
| } | |||
| } | |||
|
|
|||
| ::slotted([slot="mobile-image"]) { | |||
| #mobile-image { | |||
There was a problem hiding this comment.
slot 속성 선택자를 더 이상 쓸 수 없어서, 그냥 아이디 선택자를 사용하였습니다.
SamTheKorean
approved these changes
Sep 7, 2024
| <ds-header></ds-header> | ||
|
|
||
| <ds-intro-section id="intro-section"></ds-intro-section> |
There was a problem hiding this comment.
현재는 사용하는 곳이 없네요! 정리 감사합니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#197 (comment) 에서 이루어진 합의에 따라서 slot을 사용하는 남아있는 섹션 컴포넌트를 모두 리디자인하였습니다. 그 결과,
index.html는 아래와 같이 단순한 구조를 가지게 되었습니다.leetcode-website/index.html
Lines 46 to 60 in c6b4c7f
한 가지 흥미로운 side benefit은 웹 컴포넌트에서 세어 나오는 텍스트가 없어서 이제 FOUC 이슈에 대해서 걱정할 필요가 없어졌다는 것입니다. 그래서 PR #187 에서 추가된 display trick도 제거하였습니다.
Checklist before merging