Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add author-link attribute in ParticipantReview #182

Conversation

yolophg
Copy link
Contributor

@yolophg yolophg commented Jul 30, 2024

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@yolophg
Copy link
Contributor Author

yolophg commented Jul 30, 2024

@DaleSeo @nhistory author-link attribute까지 추가하여 아래와 같이 최종적으로 반영 완료되었습니다.
이름에 링크 연결, 링크 스타일(a11y 포함) 최종 확인 부탁드립니다!
레코딩 => https://github.com/user-attachments/assets/a42c4e2d-85c1-4a82-98da-6a59e0e25ec3
Screenshot 2024-07-30 at 10 44 02
Screenshot 2024-07-30 at 10 44 12

추가로, 스타일과 a11y 모두 step 내 link와 동일하게 아래와 같이 반영하였습니다.

  • active
Screenshot 2024-07-30 at 10 32 00
  • hover
Screenshot 2024-07-30 at 10 32 07
  • focus
Screenshot 2024-07-30 at 10 32 37
  • focus-visible
Screenshot 2024-07-30 at 10 32 59

@nhistory
Copy link
Contributor

@yolophg 넵 잘 작업된 것 같아요!
혹시 지금 리뷰의 텍스트와 이름 사이에 font-weight 차이가 있나요?
원래 피그마에서는 이름이 한 단계 더 굵은 weight을 가지게 되어 있었거든요.

@yolophg
Copy link
Contributor Author

yolophg commented Jul 31, 2024

@yolophg 넵 잘 작업된 것 같아요! 혹시 지금 리뷰의 텍스트와 이름 사이에 font-weight 차이가 있나요? 원래 피그마에서는 이름이 한 단계 더 굵은 weight을 가지게 되어 있었거든요.

해당 부분 언급해주셔서 감사합니다! 이 컴포넌트에서 author와 review content 둘 다 모두 font weight 적용이 안되어있어서, 피그마 참고하여 아래와 같이 수정하였습니다 :)
Screenshot 2024-07-30 at 23 51 48

@yolophg yolophg marked this pull request as ready for review July 31, 2024 03:54
@yolophg yolophg requested a review from a team as a code owner July 31, 2024 03:54
Copy link
Contributor

@nhistory nhistory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yolophg 수고 많으셨습니다 👏👏

@yolophg yolophg force-pushed the 181-add-personal-linkedin-or-github-link-to-author-name-in-participantreview branch from e11e22e to 2b4a49c Compare July 31, 2024 13:18
@yolophg yolophg force-pushed the 181-add-personal-linkedin-or-github-link-to-author-name-in-participantreview branch from 2b4a49c to b2474ea Compare July 31, 2024 13:26
@yolophg yolophg merged commit d54a431 into main Jul 31, 2024
@yolophg yolophg deleted the 181-add-personal-linkedin-or-github-link-to-author-name-in-participantreview branch July 31, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add personal Linkedin or Github link to author name in ParticipantReview
2 participants