Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove async, defer attributes in script tag #152

Merged
merged 1 commit into from
Jul 16, 2024
Merged

fix: remove async, defer attributes in script tag #152

merged 1 commit into from
Jul 16, 2024

Conversation

sounmind
Copy link
Member

@sounmind sounmind commented Jul 16, 2024 •
edited
Loading

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@sounmind sounmind linked an issue Jul 16, 2024 that may be closed by this pull request
remove unnecessary attributes of the script element in index.html #150
Closed
@sounmind sounmind changed the title fix: remove async, defer attribute in script tag fix: remove async, defer attributes in script tag Jul 16, 2024
@sounmind sounmind closed this Jul 16, 2024
@sounmind sounmind force-pushed the 150-refactor-script-tag-in-indexhtml branch from b45a005 to 5bbc42d Compare July 16, 2024 20:43
@sounmind sounmind reopened this Jul 16, 2024
@sounmind sounmind marked this pull request as ready for review July 16, 2024 20:44
@sounmind sounmind requested a review from a team as a code owner July 16, 2024 20:44
@sounmind sounmind merged commit 991b9cc into main Jul 16, 2024
1 check passed
@sounmind sounmind deleted the 150-refactor-script-tag-in-indexhtml branch July 16, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamTheKorean SamTheKorean SamTheKorean approved these changes

Assignees

@sounmind sounmind

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove unnecessary attributes of the script element in index.html
2 participants
@sounmind @SamTheKorean