Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : hide the unstyled text by selecting not yet defined component t… #151

Closed
wants to merge 1 commit into from
Closed

fix : hide the unstyled text by selecting not yet defined component t… #151

wants to merge 1 commit into from

Conversation

SamTheKorean
Copy link
Contributor

@SamTheKorean SamTheKorean commented Jul 15, 2024 •
edited
Loading

…o avoid foud issue

Checklist before merging

  • Link an issue with the pull request
  • Ensure no errors or warnings on the browser console
  • Avoid additional major pushes after approval (if necessary, request a new review)

@SamTheKorean SamTheKorean requested a review from a team as a code owner July 15, 2024 22:38
@SamTheKorean SamTheKorean linked an issue Jul 15, 2024 that may be closed by this pull request
Needs to be fixed : Brief flash of unstyled content (FOUC) #149
Closed
@SamTheKorean
Copy link
Contributor Author

SamTheKorean commented Jul 15, 2024 •
edited
Loading

Before the changes when refreshing

Screen.Recording.2024-07-15.at.6.37.15.PM.mov

After making changes when refreshing

Screen.Recording.2024-07-15.at.6.39.23.PM.mov

DaleSeo
DaleSeo reviewed Jul 15, 2024
View reviewed changes
global-styles.css Outdated
Comment on lines 1 to 9
ds-hero:not(:defined) {
display: inline-block;
height: 100vh;
opacity: 0;
}

ds-button-link:not(:defined) {
opacity: 0;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쌩뚱맞게 컴포넌트 스타일이 왜 전역으로 올라오나요? 😨

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

앗 곰곰히 생각해보니까 전혀 잘못생각했습니다..!

DaleSeo
DaleSeo reviewed Jul 15, 2024
View reviewed changes
Copy link
Contributor

@DaleSeo DaleSeo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamTheKorean 이슈를 보니 플래닝 때 협의가 되지 않은 티켓이네요. 급한 사안이 아니라면 다음 모임 때 문제에 대해서 팀원들과 공유해주시고 어떻게 해결할지 기술 논의 후에 수정을 진행하면 어떨까요?

@SamTheKorean
Copy link
Contributor Author

이슈를 보니 플래닝 때 협의가 되지 않은 티켓이네요. 급한 사안이 아니라면 다음 모임 때 문제에 대해서 팀원들과 공유해주시고 어떻게 해결할지 기술 논의 후에 수정을 진행하면 어떨까요?

넵 알겠습니다!

@SamTheKorean
Copy link
Contributor Author

이슈를 보니 플래닝 때 협의가 되지 않은 티켓이네요. 급한 사안이 아니라면 다음 모임 때 문제에 대해서 팀원들과 공유해주시고 어떻게 해결할지 기술 논의 후에 수정을 진행하면 어떨까요?

넵 알겠습니다! 버그라고 판단해서 우선 이슈만들어서 올렸는데 같이 논의해보는게 더 좋을 것 같습니다!

@SamTheKorean
Copy link
Contributor Author

그럼 이번 PR은 닫으면 될까요?

@SamTheKorean SamTheKorean marked this pull request as draft July 16, 2024 02:25
SamTheKorean
SamTheKorean commented Jul 16, 2024
View reviewed changes
index.html
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

component 상위에서 선택해야 하므로 index.html에 넣는게 가장 적절할 거라 판단해서 여기에 넣었습니다!

@SamTheKorean SamTheKorean deleted the sam/149 branch July 19, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaleSeo DaleSeo DaleSeo left review comments

Assignees

@SamTheKorean SamTheKorean

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Needs to be fixed : Brief flash of unstyled content (FOUC)
2 participants
@SamTheKorean @DaleSeo