fix: merge two constructors in footerlink

DaleStudy · Jun 11, 2024 · 1290e2a · 1290e2a
1 parent 4714ac9
commit 1290e2a
Showing 1 changed file with 10 additions and 13 deletions.
diff --git a/components/footer-link/footer-link.js b/components/footer-link/footer-link.js
@@ -13,26 +13,23 @@ class FooterLink extends HTMLElement {
     super();
     const shadow = this.attachShadow({ mode: "open" });
     shadow.appendChild(template.content.cloneNode(true));
+    this.linkElement = shadow.getElementById("link");
+    this.updateLink(this.getAttribute("href"));
   }
 
   static get observedAttributes() {
     return ["href"];
   }
 
-  constructor() {  
-    this.linkElement = shadow.getElementById("link");  
-    this.updateLink(this.getAttribute("href"));  
-  }  
-
-  attributeChangedCallback(name, oldValue, newValue) {  
-    if (name === "href") {  
-        this.updateLinkHref(newValue);  
-    }  
-  }  
+  attributeChangedCallback(name, oldValue, newValue) {
+    if (name === "href") {
+      this.updateLink(newValue);
+    }
+  }
 
-  updateLink(href) {  
-    this.linkElement.setAttribute("href", href);  
-  }  
+  updateLink(href) {
+    this.linkElement.setAttribute("href", href);
+  }
 }
 
 window.customElements.define("footer-link", FooterLink);