Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Fixed a faulty null check #409

Merged
merged 2 commits into from
Dec 20, 2023
Merged

Bugfix: Fixed a faulty null check #409

merged 2 commits into from
Dec 20, 2023
+3 −3

Conversation

jinensetpal
Copy link
Collaborator

No description provided.

@jinensetpal jinensetpal added the bug Something isn't working label Dec 20, 2023
@jinensetpal jinensetpal self-assigned this Dec 20, 2023
@dagshub DagsHub
Copy link

dagshub bot commented Dec 20, 2023

Join the discussion on DagsHub!

kbolashev
kbolashev requested changes Dec 20, 2023
View reviewed changes
Copy link
Member

@kbolashev kbolashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to still check IF "prefix" exists there, but I didn't think that the value itself could be None, so thanks for catching it.

dagshub/data_engine/model/datasource_state.py Outdated Show resolved Hide resolved
@kbolashev kbolashev merged commit 151de60 into master Dec 20, 2023
7 checks passed
@kbolashev kbolashev deleted the jinen/bugfix branch December 20, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbolashev kbolashev Awaiting requested review from kbolashev

Assignees

@jinensetpal jinensetpal

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jinensetpal @kbolashev