Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to download a repo folder (including CLI) #389

Merged
merged 20 commits into from
Feb 19, 2024
Merged

Add ability to download a repo folder (including CLI) #389

merged 20 commits into from
Feb 19, 2024

Conversation

kbolashev
Copy link
Member

This PR adds a capability to download a folder in the repository.
The download function is exposed in two places:

  • On the RepoAPI object
  • In the CLI as dagshub download

Caveats/possible improvements:

  • Nonrecursive download doesn't create folder entries (only downloads files)
  • The repo traversal is single-threaded

@kbolashev kbolashev added enhancement New feature or request UX labels Nov 19, 2023
@kbolashev kbolashev requested a review from guysmoilov November 19, 2023 12:07
@kbolashev kbolashev self-assigned this Nov 19, 2023
guysmoilov
guysmoilov requested changes Dec 19, 2023
View reviewed changes
dagshub/common/cli.py Outdated Show resolved Hide resolved
dagshub/common/cli.py Show resolved Hide resolved
dagshub/common/cli.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
@kbolashev kbolashev requested a review from guysmoilov December 24, 2023 16:42
guysmoilov
guysmoilov requested changes Dec 28, 2023
View reviewed changes
dagshub/common/api/repo.py Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Outdated Show resolved Hide resolved
dagshub/common/api/repo.py Show resolved Hide resolved
@kbolashev kbolashev requested a review from guysmoilov January 1, 2024 13:35
@guysmoilov guysmoilov merged commit 0cc3be2 into master Feb 19, 2024
7 checks passed
@guysmoilov guysmoilov deleted the enhancement/download-repo-folder branch February 19, 2024 18:08
@kbolashev kbolashev mentioned this pull request Dec 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysmoilov guysmoilov guysmoilov approved these changes

Assignees

@kbolashev kbolashev

Labels
enhancement New feature or request UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kbolashev @guysmoilov