Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix and clean short rebate logic #98

Merged
merged 1 commit into from
Nov 16, 2024
Merged

fix and clean short rebate logic #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 7 additions & 16 deletions home/views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,10 +196,14 @@ def rebate(request):
text = "Please fill the rebate of this period only"
elif not is_not_duplicate(student, start_date, end_date):
text = "You have already applied for rebate during this duration"
elif 0 < rebate_days < 2:
text = "Min no of days for rebate is 2"
elif before_rebate_days < 2:
text = "Form needs to be filled atleast 2 days prior the comencement of leave."
else:
if not period_start <= start_date <= period_end:
short_left_rebate = LeftShortRebate(
email=str(request.user.email),
email=student.email,
start_date=start_date,
end_date=end_date,
date_applied=date.today(),
Expand All @@ -209,7 +213,7 @@ def rebate(request):
upper_cap_check = -1
elif not period_start <= end_date <= period_end:
short_left_rebate = LeftShortRebate(
email=str(request.user.email),
email=student.email,
start_date=period_end + timedelta(days=1),
end_date=end_date,
date_applied=date.today(),
Expand All @@ -228,12 +232,7 @@ def rebate(request):
"You can only apply for max 8 days in a period. Days left for this period: "
+ str(upper_cap_check)
)
elif (
text == ""
and (rebate_days) <= 7
and rebate_days >= 2
and before_rebate_days >= 2
):
elif text == "":
r = Rebate(
email=student,
allocation_id=allocation_id,
Expand All @@ -243,14 +242,6 @@ def rebate(request):
)
r.save()
text = "You have successfully submitted the rebate. Thank You! You shall recieve a confirmation mail, If not please contact the Dining Warden."
elif 0 < rebate_days < 2:
text = "Min no of days for rebate is 2"
elif before_rebate_days < 2:
text = "Form needs to be filled atleast 2 days prior the comencement of leave."
elif rebate_days > 7:
text = "Max no of days for rebate is 7"
elif before_rebate_days < 0:
text = "Please enter the correct dates"
elif not text:
text = "Your rebate application has been rejected due to non-compliance of the short term rebate rules"
except Allocation.DoesNotExist:
Expand Down
Loading