Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct relative mouse input handling #634

Merged
merged 1 commit into from
Jun 17, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -615,21 +615,6 @@ endif()
# SDL, required for all targets on win32 because of iconv and SDL_SetHint(SDL_TIMER_RESOLUTION, 0)
if (BUILD_CLIENT OR WIN32)
find_package(SDL2 REQUIRED)
# Non-Linux systems use pre-compiled SDL we provide,
# so no one of them is using unapproved version.
if(LINUX)
find_package(SDL2 QUIET CONFIG)
if(SDL2_VERSION)
if (SDL2_VERSION VERSION_GREATER_EQUAL "2.0.16"
AND SDL2_VERSION VERSION_LESS_EQUAL "2.0.20")
message(WARNING "SDL ${SDL2_VERSION} between version 2.0.16 and 2.0.20 is known to be buggy, see https://github.com/DaemonEngine/Daemon/issues/600")
endif()
else()
# CMake may be able to find SDL2 without supporting CONFIG
# If sdl2-config.cmake or SDL2Config.cmake isn't provided.
message(STATUS "SDL version is unknown, version can't be checked for known bugs")
endif()
endif()

include_directories(${SDL2_INCLUDE_DIR})

Expand Down
9 changes: 0 additions & 9 deletions src/engine/sys/sdl_input.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1082,15 +1082,6 @@ static void IN_ProcessEvents( bool dropInput )
else
{
Com_QueueEvent( Util::make_unique<Sys::MouseEvent>(e.motion.xrel, e.motion.yrel) );
#if defined( __linux__ ) || defined( __BSD__ )
if ( !in_nograb->integer && ( e.motion.xrel || e.motion.yrel ) )
{
// work around X window managers and edge-based workspace flipping
// - without this, we get LeaveNotify, no mouse button events, EnterNotify;
// we would likely miss some button presses and releases.
IN_CenterMouse();
}
#endif
}
}
break;
Expand Down