Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/retaining chain connection #844

Merged
merged 1 commit into from
May 9, 2022
Merged

Fix/retaining chain connection #844

merged 1 commit into from
May 9, 2022

Conversation

dcrescimbeni
Copy link
Contributor

Description

Closes #840

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested manually.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@dcrescimbeni dcrescimbeni changed the base branch from master to develop May 9, 2022 16:33
0xvangrim
0xvangrim approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@0xvangrim 0xvangrim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcrescimbeni dcrescimbeni merged commit 39a4ddd into DXgovernance:develop May 9, 2022
@dcrescimbeni dcrescimbeni deleted the fix/retaining-chain-connection branch May 9, 2022 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xvangrim 0xvangrim 0xvangrim approved these changes

@rossneilson rossneilson rossneilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retaining Chain connection on refresh
3 participants
@dcrescimbeni @rossneilson @0xvangrim