Feature/add minting to transfer 726 #792
Conversation
…sync with a contract
0xvangrim
requested review from
carlbarrdahl,
mprasanjith,
MiltonTulli,
rossneilson and
hhamud
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: fb94b07 😎 Browse the preview: https://bafybeif7msfu4pewfrumw2wwctsqndmdb7sao3ony4tmtng4fas3ctbmiy.ipfs.dweb.link |
| console.log({ tokenData }); | ||
| console.log(tokenData.symbol); |
| const { guild_id: guildId } = | ||
| useParams<{ chain_name?: string; guild_id?: string }>(); | ||
| const { data } = useGuildConfig(guildId); | ||
| const { data: tokenData } = useERC20Info(data?.token); | ||
| const totalSupply = useBigNumberToNumber(tokenData?.totalSupply, 18); | ||
|
|
||
| const parsedData = useMemo<REPMintState>(() => { | ||
| if (!decodedCall) return null; | ||
| return { | ||
| toAddress: decodedCall.args.to, | ||
| amount: decodedCall.args.amount, | ||
| }; | ||
| }, [decodedCall]); | ||
|
|
||
| const { imageUrl } = useENSAvatar(parsedData?.toAddress, MAINNET_ID); |
There was a problem hiding this comment.
This chunk of code is very similar throughout the REPMint components. I suggest that it would be worth placing this processing into its own hook.
| } | ||
| }; | ||
| return ( | ||
| <div> |
| console.log({ tokenData }); | ||
| console.log(tokenData.symbol); |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 0334f04 😎 Browse the preview: https://bafybeie4pfotyuhybfs7aj6sotwvxtafu7w53qvqaqy63s2q4akewijosy.ipfs.dweb.link |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: d311fbf 😎 Browse the preview: https://bafybeiewcgf7rgxhzy46khw73b4a26ndqyhcdglcjhbeuvzie2dgsxqssu.ipfs.dweb.link |
|
✔️ Preview deployment is ready! 🔨 Explore the source changes: 12d68ee 😎 Browse the preview: https://bafybeicebedbm5yjuvfyqwocatwr2geapi3dtow6s33774nmmlfvte7oby.ipfs.dweb.link |
|
Hello guys @MiltonTulli @hhamud, back from the dead here in ETHAmsterdam :D. Thanks for the comments, the latest commits do:
|
Description
Issue: #726
ERC20SnapshotRepmint-functionTODO:
ModalRepMintEditorRepMintInfoLineRepMintSummaryType of change
How Has This Been Tested?
This has only been manually tested. Since the dev-script is currently not working with REP guilds, it was not possible to execute the actual action. Thus, it needs to be tested that it actually sends the correct data in the calldata.
Checklist: