Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dev script #779

Merged
merged 3 commits into from
Apr 7, 2022
Merged

Fix dev script #779

merged 3 commits into from
Apr 7, 2022

Conversation

AugustoL
Copy link
Member

@AugustoL AugustoL commented Apr 7, 2022

Description

Small changes to bring back developer script and also fix bug in the CacheService that breaks down using default xdai RPC
Closes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@AugustoL AugustoL requested a review from rossneilson April 7, 2022 17:12
@AugustoL AugustoL changed the title Fix/dev script Fix dev script Apr 7, 2022
@AugustoL AugustoL requested a review from a team April 7, 2022 17:12
@github-actions
Copy link

github-actions bot commented Apr 7, 2022

✔️ Preview deployment is ready!

🔨 Explore the source changes: 03d39d8

😎 Browse the preview: https://bafybeif7jc45uxn7g2ejkntk35dbv6rudaddv7wolkor23t4xs26ipuvx4.ipfs.dweb.link

@AugustoL AugustoL merged commit 48b4eee into DXgovernance:develop Apr 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rossneilson rossneilson rossneilson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AugustoL @rossneilson