Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement dynamic generic function editor form. #763

Conversation

mprasanjith
Copy link
Member

Description

Implements dynamically generating the function call editor from the contract registry, when creating a new generic action.

Partially completes #721.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Tested locally, with yarn dev.

Checklist:

  • My code follows the existing style of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any UI changes have been tested and made responsive for mobile views

@mprasanjith mprasanjith added Enhancement New feature or request Guilds labels Mar 31, 2022
@mprasanjith mprasanjith requested review from hhamud and a team March 31, 2022 09:02
@mprasanjith mprasanjith self-assigned this Mar 31, 2022
@github-actions
Copy link

✔️ Preview deployment is ready!

🔨 Explore the source changes: d7eebf8

😎 Browse the preview: https://bafybeihx3s6t2pj7ycqaqfkka4mynowozt2hrn7hfaeueflzblucqt7gcu.ipfs.dweb.link

@mprasanjith mprasanjith requested a review from rossneilson April 2, 2022 04:46
@mprasanjith mprasanjith merged commit 21093be into DXgovernance:develop Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request Guilds
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants