Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Determine guild implementation #696

Closed
rossneilson opened this issue Mar 14, 2022 · 1 comment
Closed

Determine guild implementation #696

rossneilson opened this issue Mar 14, 2022 · 1 comment
Assignees
@MiltonTulli
Labels
Enhancement New feature or request Guild Implementation Support Epic Guilds
Milestone
v1.0.12

Comments

@rossneilson
Copy link
Collaborator

We need a hook or function to determine what implementation a given guild is using.
We should be able to take the address, find the bytecode and then match that to a local copy of guild implementation bytecodes to determine what implementation is being used.
The function should return an enum defaulting to the base guild implementation.

As part of this issue you should also deploy a SnapshotRepERC20Guild to test.
We should store the bytecode alongside the abi we use for typechain.
@rossneilson rossneilson added Enhancement New feature or request Guilds labels Mar 14, 2022
@rossneilson rossneilson added this to the v1.0.12 milestone Mar 14, 2022
@rossneilson rossneilson moved this to Backlog in Sprints Mar 15, 2022
@rossneilson
Copy link
Collaborator Author

#702

@MiltonTulli MiltonTulli self-assigned this Mar 21, 2022
@MiltonTulli MiltonTulli mentioned this issue Mar 21, 2022
Merged
12 tasks
@MiltonTulli MiltonTulli moved this from Backlog to In Progress in Sprints Mar 22, 2022
@MiltonTulli MiltonTulli moved this from In Progress to Review in Sprints Mar 22, 2022
MiltonTulli added a commit that referenced this issue Mar 25, 2022
@MiltonTulli
#696/guild implementation (#710)
17433ef 
* Create hook to determine guild implementation

* Create hook to determine guild implementation

* refactor

* Create script to copy bytecodes from artifacts, update hook to use those

* format

* refator & fix jsdoc

* fix typo
@MiltonTulli MiltonTulli moved this from Review to Ready in Sprints Mar 25, 2022
@MiltonTulli MiltonTulli moved this from Ready to Done in Sprints Mar 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MiltonTulli MiltonTulli

Labels
Enhancement New feature or request Guild Implementation Support Epic Guilds
Projects
Sprints
Status: Done
Milestone
v1.0.12
Development

No branches or pull requests
2 participants
@MiltonTulli @rossneilson