Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix token weights #316

Merged
merged 13 commits into from
Mar 1, 2023
Merged

Fix token weights #316

merged 13 commits into from
Mar 1, 2023

Conversation

MiltonTulli
Copy link
Member

@MiltonTulli MiltonTulli commented Feb 22, 2023 •
edited
Loading

Summary:

  • Calling setComposition should not modify the balance of the user at a certain snapshot ID. This pr uses the global snapshot to store/retrieve token weight at a certain snapshot ID.
  • Use snapshot to set/get minStakingTokensLocked
  • Allow DAOReputation to mint/burn 0 amount without revert
  • Update DXDStaking & VotingPower documentation

@MiltonTulli MiltonTulli requested a review from fnanni-0 February 22, 2023 04:06
@MiltonTulli MiltonTulli force-pushed the fix/vp-snapshoted-weights branch from f2b7b51 to ff0014b Compare February 24, 2023 20:25
@MiltonTulli MiltonTulli mentioned this pull request Feb 26, 2023
Merged
@MiltonTulli MiltonTulli marked this pull request as draft February 28, 2023 14:29
@MiltonTulli MiltonTulli marked this pull request as ready for review March 1, 2023 14:10
@MiltonTulli MiltonTulli merged commit 43e23f8 into DXgovernance:feat/voting-power Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnanni-0 fnanni-0 fnanni-0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MiltonTulli @fnanni-0