Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clang tidy/fix readability not checked #75

Merged
merged 2 commits into from
Mar 3, 2024
Merged

Clang tidy/fix readability not checked #75

merged 2 commits into from
Mar 3, 2024

Conversation

JoshuaLau0220
Copy link
Collaborator

@JoshuaLau0220 JoshuaLau0220 commented Mar 3, 2024 •
edited
Loading

Don't delete this branch yet --- still applying more lint fixes!

Check List

  1. Does your submission pass tests by running make test?
  2. If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
  3. Have you linted your code locally with make lint before submission?

Added

Changed

Fixed

  • fix clang-tidy format error (which results in a lot of errors being emitted for now)
  • fix numerous lint warnings

Removed

@JoshuaLau0220 JoshuaLau0220 merged commit 038cc11 into develop Mar 3, 2024
4 checks passed
@chinyi0523 chinyi0523 mentioned this pull request Apr 26, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@JoshuaLau0220