Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove sanity check which does not work with new geometry #178

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Remove sanity check which does not work with new geometry #178

merged 1 commit into from
Nov 14, 2024

Conversation

jdkio
Copy link
Contributor

@jdkio jdkio commented Nov 6, 2024

Removes sanity check to fix issue #147. I thought it was already fixed but it broke recent tests of the new geometry here

@jdkio jdkio requested review from LiamOS and AsaNehm November 6, 2024 22:25
AsaNehm
AsaNehm approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@AsaNehm AsaNehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just commented the check out, but should be fine to take it out as well

LiamOS
LiamOS approved these changes Nov 14, 2024
View reviewed changes
Copy link
Member

@LiamOS LiamOS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
Definitely not needed.

@AsaNehm AsaNehm merged commit 90523e2 into main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsaNehm AsaNehm AsaNehm approved these changes

@LiamOS LiamOS LiamOS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdkio @LiamOS @AsaNehm