-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge feature/kalman, TMS_Bar and TMS_Kalman small changes #167
base: main
Are you sure you want to change the base?
Conversation
Should be behaving substantially better with this, but not perfect. Still leaves the detector sometimes. Want to wait for some feedback for Asa before tackling this fully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config change I fully approve. The Bar stuff looks reasonable. For the Kalman stuff I read through it, but I don't have the time to fully understand it, so I'll trust you on this
Validation plots from one file located in For future PRs, should we define some minimal set of required validation plots that should be presented, or do it depending on the content of the PRs? |
Solved merging conflict by removing the sanity check in TMS_Bar that was still in in this branch but removed on main |
config/TMS_Default_Config.toml:
TMS_Bar:
TMS_Kalman:
TMS_Reco
TMS_Track
TMS_TreeWriter