Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed Modal.Form ts problems #350

Merged
merged 3 commits into from
Jun 7, 2023
Merged

fix: fixed Modal.Form ts problems #350

merged 3 commits into from
Jun 7, 2023

Conversation

Zaoei
Copy link
Contributor

@Zaoei Zaoei commented Jun 2, 2023

  • 修复在使用时，ts 报错问题

@Zaoei Zaoei added the bug Something isn't working label Jun 2, 2023
@Zaoei Zaoei added this to the Next Version(4.0.0） milestone Jun 2, 2023
@Zaoei Zaoei requested a review from mumiao June 2, 2023 08:10
mumiao
mumiao reviewed Jun 2, 2023
View reviewed changes
src/modal/demos/advance.tsx Outdated Show resolved Hide resolved
@Zaoei Zaoei changed the title fix: fixed Modal.Form ts problems WIP:fix: fixed Modal.Form ts problems Jun 6, 2023
@Zaoei
Copy link
Contributor Author

Zaoei commented Jun 6, 2023

先放着，等确认资产没问题后，在合

@Zaoei Zaoei changed the title WIP:fix: fixed Modal.Form ts problems fix: fixed Modal.Form ts problems Jun 7, 2023
mumiao
mumiao reviewed Jun 7, 2023
View reviewed changes
src/modal/form.tsx Show resolved Hide resolved
src/modal/form.tsx Show resolved Hide resolved
src/modal/demos/classComponent.tsx Outdated Show resolved Hide resolved
src/modal/demos/classComponent.tsx Show resolved Hide resolved
src/modal/demos/classComponent.tsx Outdated Show resolved Hide resolved
src/modal/form.tsx Outdated Show resolved Hide resolved
src/modal/demos/basics.tsx Outdated Show resolved Hide resolved
src/modal/demos/basics.tsx Outdated Show resolved Hide resolved
@Zaoei Zaoei force-pushed the modal_form_issuse_types branch from 3d56461 to 5eda3c7 Compare June 7, 2023 03:13
@mumiao mumiao merged commit aaabc2a into DTStack:master Jun 7, 2023
@mumiao
Copy link
Collaborator

mumiao commented Jun 7, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mumiao mumiao mumiao left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
Next Version(4.0.0）
Development

Successfully merging this pull request may close these issues.
2 participants
@Zaoei @mumiao