Issue predb status cleanup #9242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…efault size) - IT proving issue
…efault size) - Fix: - Query with 0 rows to get total number of records to process - Process them in batches of 100
tdonohue
added
bug
backend: Solr
Atmire-github
force-pushed
the
w2p-90830-104654_issue-8125_pr-8267_Issue-stale-record-cleanup
branch
from
91f53c2 to
34bd5f1
Compare
…e-8125_pr-8267_Issue-stale-record-cleanup
Atmire-github
force-pushed
the
w2p-90830-104654_issue-8125_pr-8267_Issue-stale-record-cleanup
branch
from
34bd5f1 to
e1cfb74
Compare
alanorth
removed
the
port to dspace-7_x
tdonohue
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
👍 Thanks @MarieVerdonck ! Code looks good. I was able to verify this works locally by bulk importing 20 items and checking Solr to ensure that they all had database_status:predb: http://localhost:8983/solr/#/search/query?q=database_status:predb&q.op=OR&indent=true
Then, I set solr-database-resync.time-until-reindex = 0 and ran the solr-database-resync script from the Processes UI.
After doing so, all 20 items were reindexed & have the database_status:predb flag removed.
|
Ported to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
Description
The script to update solr docs with predb state (from eg Import script) only processed the first 10 docs with
database_status:predb(default solr page size)Instructions for Reviewers
Add more than 10 new items
Check in solr they have
database_status:predbRun item-database-status script with config item-database-status.time-until-reindex set to 0 for example (so all solr records indexed before script run time) are updated
Verify all the docs for the new items no longer have predb status
For automated test: Run updated
SolrDatabaseResyncITbefore fix & verify script fails to clear status field for more than 10 docsChecklist
pom.xml), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.