Skip to content

Commit

Permalink
Comment out SM64DS from laggy game check
Browse files Browse the repository at this point in the history 
Fixes Mario's Holiday on DSi
  • Loading branch information
@RocketRobz
RocketRobz committed Sep 30, 2018
1 parent 4815683 commit 719ffc0
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions cardengine/arm9/source/cardengine.c
View file
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ static void getAsyncSector(void) {

static inline bool isGameLaggy(const tNDSHeader* ndsHeader) {
const char* romTid = getRomTid(ndsHeader);
return (strncmp(romTid, "ASM", 3) == 0 // Super Mario 64 DS (fixes sound crackles)
|| strncmp(romTid, "AP2", 3) == 0 // Metroid Prime Pinball
//return (strncmp(romTid, "ASM", 3) == 0 // Super Mario 64 DS (fixes sound crackles, breaks Mario's Holiday)
return (strncmp(romTid, "AP2", 3) == 0 // Metroid Prime Pinball
|| strncmp(romTid, "ADM", 3) == 0 // Animal Crossing: Wild World (fixes some sound crackles)
|| strncmp(romTid, "APT", 3) == 0 // Pokemon Trozei (slightly boosts load speed)
|| strncmp(romTid, "A2D", 3) == 0 // New Super Mario Bros. (fixes sound crackles)
Expand Down

3 comments on commit 719ffc0

@Arisotura
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so basically... does this mean SM64DS gets crackly sound but we get to play one hack that pulls lame lockdown/DRM tricks?

@skawo
Copy link

@skawo skawo commented on 719ffc0 Oct 1, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^
Seems kind of nonsense to go out of your way to support a hack which purposefully goes out of its way to be as incompatible with everything as it can.

@RocketRobz
Copy link
Member Author

@RocketRobz RocketRobz commented on 719ffc0 Oct 1, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though the sound fix option breaks some games, it works fine for SM64DS (last time I tried it), so sound fix can be used to fix the crackles.

Please sign in to comment.