Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update standard.md #45

Merged
merged 5 commits into from
Feb 4, 2021
Merged

Update standard.md #45

merged 5 commits into from
Feb 4, 2021

Conversation

Not-Whiskey
Copy link
Collaborator

Made edits for grammar and consistency in capitalization. Added hyperlink for the Principles for Digital Development so as to align with other suggested resources made throughout which were hyperlinked.

Made edits for grammar and consistency in capitalization. Added hyperlink for the Principles for Digital Development so as to align with other suggested resources made throughout which were hyperlinked.
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Not-Whiskey for your contribution and congratulations on your first Pull Request 💪

I have noticed some additional areas that need attention and I have flagged below. Could you please address them before I can approve and merge it?

Thanks again 🙏

standard.md Outdated Show resolved Hide resolved
standard.md Outdated Show resolved Hide resolved
standard.md Outdated Show resolved Hide resolved
@lacabra lacabra self-requested a review February 4, 2021 20:21
Copy link
Contributor

@lacabra lacabra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic! Thanks for addressing my requests for change so promptly!
This looks good to me; thanks @Not-Whiskey !

@lacabra lacabra merged commit 9837dc2 into master Feb 4, 2021
@lacabra lacabra deleted the Not-Whiskey-patch-1 branch February 4, 2021 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants