Clean baseline 20240203 #2314
Merged
Clean baseline 20240203 #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vmcj
force-pushed
the
clean_baseline_20240203
branch
from
b763203 to
8b7bc8b
Compare
nickygerritsen
approved these changes
Feb 4, 2024
Most types where based on dumping the input/output object otherwise copied from other functions where the the output is either the input for the function or the other way around. This should make it easier for PHPStan to discover wrong or unused code. Also disabled scanning for the Test fixtures as we do the same things for the tests. Removed one generic php-stan line as this was fixed according to PHPStan itself. Further work can be done to change the Object arrays to be less generic, and rescrict that it would only implement our Deletable objects, for now this doesn't add enough new information compared to the work.
vmcj
force-pushed
the
clean_baseline_20240203
branch
from
8b7bc8b to
f73f856
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Has one candidate for a DTO.