Import relative contest times #2221
Conversation
We already accept this for the UI, now also accept this in the API. This means we read more lenient than CLICS requires us for the API.
This is a candidate to refactor to a more generic solution but as the startTime is closely related to the starttime it makes sense to not change this just before a planned release.
This makes sure the 2 are in sync.
| @@ -564,6 +564,7 @@ public function setStarttimeString(string $starttimeString): Contest | |||
| { | |||
| $this->starttimeString = $starttimeString; | |||
|
|
|||
| $this->starttime = $this->getAbsoluteTime($starttimeString); | |||
There was a problem hiding this comment.
If this wasn't here to begin with, I'm wondering if there was maybe a good reason for this.
There was a problem hiding this comment.
I think in general if we want the same/similar logic for the UI and API, then we should rethink where and how parsing the input is handled in a common place. It feels that this is duplicating code in the import service that's already existing in other places.
There was a problem hiding this comment.
If this wasn't here to begin with, I'm wondering if there was maybe a good reason for this.
I had the same question, so I was planning to not merge this PR before having discussed this at the hackathon.
I think in general if we want the same/similar logic for the UI and API, then we should rethink where and how parsing the input is handled in a common place. It feels that this is duplicating code in the import service that's already existing in other places.
I agree, but than I prefer to move this one for after the release as mentioned in the commit message.
That we store the time string as is (i.e. as relative time) and present it back to the user is intentional. If we move the contest start, and the user entered relative times, the respective other times need to move as well. |
Than this shouldn't be merged and requires some/loads of rework. |
|
Not possible in current format. |
This targets #2072
This has one slight flaw, the relative time is changed to an absolute time and stored as such. I'm not sure if there is a proper fix for this.
Also side-effect to test if the CI now works again.