Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address current failing sphinx packages for development #2204

Closed
wants to merge 1 commit into from

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Nov 4, 2023

We do generate the docs already before so the virtualenv is not that problematic. I will investigate if we can do something else so we don't need this but for now this is the best we can do.

This does block releasing though (although this also exists in the older releases) as a dependency for us is broken.

Closes: #2199

We do generate the docs already before so the virtualenv is not that
problematic.
@eldering
Copy link
Member

eldering commented Nov 4, 2023

We do generate the docs already before so the virtualenv is not that problematic. I will investigate if we can do something else so we don't need this but for now this is the best we can do.

This does block releasing though (although this also exists in the older releases) as a dependency for us is broken.

Closes: #2199

This explanation is confusing: we generate the doce before what? How does that make the virtualenv not that problematic?

Also, is #2205 an alternative for this PR?

@vmcj
Copy link
Member Author

vmcj commented Nov 4, 2023

We do generate the docs already before so the virtualenv is not that problematic. I will investigate if we can do something else so we don't need this but for now this is the best we can do.
This does block releasing though (although this also exists in the older releases) as a dependency for us is broken.
Closes: #2199

This explanation is confusing: we generate the doce before what? How does that make the virtualenv not that problematic?

In a normal release I thought (I verified and we don't) we already package the team manual. In that case only the one running make dist would need the extra virtual environment.

Also, is #2205 an alternative for this PR?

Yes, I think we should merge the other one if we accept the difference in the manual, but documenting how people can run make dist when doing development is a cleaner fix for the original issue (it was also easier to make sure we do fix this, only later did I realize how to find the actual issue).

@vmcj
Copy link
Member Author

vmcj commented Nov 26, 2023

So by making the manual ugly in the other PR mentioned above, the issue is now fixed so I'll close this one.

@vmcj vmcj closed this Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error while running make dist
2 participants