Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove JudgehostRestriction feature #1137

Merged
merged 5 commits into from
Aug 14, 2021
Merged

Conversation

vmcj
Copy link
Member

@vmcj vmcj commented Aug 13, 2021

This is to trigger the pipeline, I think a quick grep for restrictions will only show other restrictions which are another type of restrictions.

@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #1137 (4dbe830) into main (91b5085) will decrease coverage by 0.23%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1137      +/-   ##
============================================
- Coverage     43.43%   43.20%   -0.24%     
+ Complexity     5411     5333      -78     
============================================
  Files           224      220       -4     
  Lines         19098    18824     -274     
============================================
- Hits           8296     8132     -164     
+ Misses        10802    10692     -110     
Impacted Files Coverage Δ
webapp/src/Controller/API/JudgehostController.php 0.00% <ø> (ø)
webapp/src/Controller/Jury/AuditLogController.php 30.69% <ø> (+0.59%) ⬆️
webapp/src/Controller/Jury/ContestController.php 40.89% <ø> (+0.85%) ⬆️
...ebapp/src/Controller/Jury/SubmissionController.php 7.98% <0.00%> (+0.17%) ⬆️
webapp/src/Entity/Judgehost.php 39.02% <ø> (-0.11%) ⬇️
webapp/src/Form/Type/JudgehostType.php 0.00% <ø> (ø)
webapp/src/Service/CheckConfigService.php 73.19% <ø> (+0.72%) ⬆️
webapp/src/Controller/Jury/JudgehostController.php 50.00% <66.66%> (-0.44%) ⬇️
webapp/src/Controller/BaseController.php 90.54% <0.00%> (-0.46%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 91b5085...4dbe830. Read the comment docs.

@vmcj
Copy link
Member Author

vmcj commented Aug 13, 2021

Changed URLs:
jury
jury_s_change-contest_s_-1
jury_s_judgehosts
jury_s_judgehosts_s_1
jury_s_judgehosts_s_1_s_activate
jury_s_config_s_check
jury_s_judgehosts_s_edit_s_multiple
jury_s_judgehosts_s_edit_s_multiple@include_hidden=0

@vmcj vmcj marked this pull request as ready for review August 13, 2021 20:04
@vmcj vmcj force-pushed the remove_restriction branch from dc3bc42 to ebe51e6 Compare August 13, 2021 20:40
Copy link
Member

@thijskh thijskh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I’m missing a docs update.

@vmcj
Copy link
Member Author

vmcj commented Aug 14, 2021

I think I’m missing a docs update.

You mean the mention that the feature was removed? I'll add that.

@thijskh
Copy link
Member

thijskh commented Aug 14, 2021

I meant just removing the chapter in the manual. I think the manual is not the place for upgrade notes.

Copy link
Member

@thijskh thijskh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Ready to merge when build passes and commits are squashed

@thijskh thijskh merged commit 2ffec25 into DOMjudge:main Aug 14, 2021
@vmcj vmcj deleted the remove_restriction branch August 14, 2021 08:01
vmcj pushed a commit to vmcj/domjudge that referenced this pull request Nov 24, 2023
Jaap wants a reference to: DOMjudge#1137
vmcj added a commit to vmcj/domjudge that referenced this pull request Nov 24, 2023
Added a small part about how to pick up judgings together with parallel judging.

This was left over from:
DOMjudge#1137

Co-authored-by: Thijs Kinkhorst <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 24, 2023
Added a small part about how to pick up judgings together with parallel judging.

This was left over from:
#1137

Co-authored-by: Thijs Kinkhorst <[email protected]>
vmcj added a commit to vmcj/domjudge that referenced this pull request Feb 27, 2024
Added a small part about how to pick up judgings together with parallel judging.

This was left over from:
DOMjudge#1137

Co-authored-by: Thijs Kinkhorst <[email protected]>
(cherry picked from commit c9fbcaa)
vmcj added a commit that referenced this pull request Feb 28, 2024
Added a small part about how to pick up judgings together with parallel judging.

This was left over from:
#1137

Co-authored-by: Thijs Kinkhorst <[email protected]>
(cherry picked from commit c9fbcaa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants