-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incomplete markdown rendering in clarification requests #2311
Comments
We recently added that line since we had an XSS attack vector. We will investigate if we can enable some of these elements somehow. |
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this issue
Feb 10, 2024
Also sanitize only after converting to markdown. Fixes DOMjudge#2311
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this issue
Feb 10, 2024
Also sanitize only after converting to markdown. Fixes DOMjudge#2311
Turns out we needed to first run markdown, then sanitize instead of the other way around. I have added that to the above linked PR. |
nickygerritsen
added a commit
to nickygerritsen/domjudge
that referenced
this issue
Feb 10, 2024
Also sanitize only after converting to markdown. Fixes DOMjudge#2311
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 17, 2024
Also sanitize only after converting to markdown. Fixes #2311
vmcj
pushed a commit
to vmcj/domjudge
that referenced
this issue
Feb 24, 2024
Also sanitize only after converting to markdown. Fixes DOMjudge#2311
nickygerritsen
added a commit
to vmcj/domjudge
that referenced
this issue
Feb 27, 2024
Also sanitize only after converting to markdown. Fixes DOMjudge#2311
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi! SWERC 2023-24 was this weekend, here is a minor issue that we encountered with DOMjudge.
Description of the problem
Some markdown elements such as quotes or inline code blocks are not rendered correctly, for example in clarification requests.
Your environment
DOMjudge 8.3.0DEV/5502c03cc
Steps to reproduce
Expected behaviour
Mardown elements are rendered correctly
Actual behaviour
Blockquote, inline code and code blocks are note rendered properly
Any other information that you want to share?
I suspect that the culprit is this this line, where HTML escaping is done before rendering markdown, likely resulting in HTML special characters being replaced, erasing the markdown elements.
The text was updated successfully, but these errors were encountered: