Add some more forgotten return types.

DOMjudge · Jan 19, 2024 · 8439b6c · 8439b6c
1 parent c21763f
commit 8439b6c
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 20 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -10,11 +10,6 @@ parameters:
 			count: 1
 			path: webapp/src/Controller/API/AbstractRestController.php
 
-		-
-			message: "#^Method App\\\\Controller\\\\API\\\\BalloonController\\:\\:listAction\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Controller/API/BalloonController.php
-
 		-
 			message: "#^Method App\\\\Controller\\\\API\\\\GeneralInfoController\\:\\:addProblemAction\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1
@@ -40,31 +35,16 @@ parameters:
 			count: 1
 			path: webapp/src/Controller/API/JudgehostController.php
 
-		-
-			message: "#^Method App\\\\Controller\\\\API\\\\JudgehostController\\:\\:getJudgehostsAction\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Controller/API/JudgehostController.php
-
 		-
 			message: "#^Method App\\\\Controller\\\\API\\\\JudgehostController\\:\\:getVersionCommands\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1
 			path: webapp/src/Controller/API/JudgehostController.php
 
-		-
-			message: "#^Method App\\\\Controller\\\\API\\\\JudgehostController\\:\\:serializeJudgeTasks\\(\\) return type has no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Controller/API/JudgehostController.php
-
 		-
 			message: "#^Method App\\\\Controller\\\\API\\\\JudgehostController\\:\\:updateJudgeHostAction\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1
 			path: webapp/src/Controller/API/JudgehostController.php
 
-		-
-			message: "#^Method App\\\\Controller\\\\API\\\\JudgementTypeController\\:\\:getJudgementTypes\\(\\) has parameter \\$filteredOn with no value type specified in iterable type array\\.$#"
-			count: 1
-			path: webapp/src/Controller/API/JudgementTypeController.php
-
 		-
 			message: "#^Method App\\\\Controller\\\\API\\\\ProblemController\\:\\:addProblemAction\\(\\) return type has no value type specified in iterable type array\\.$#"
 			count: 1

diff --git a/webapp/src/Controller/API/BalloonController.php b/webapp/src/Controller/API/BalloonController.php
@@ -31,6 +31,7 @@ class BalloonController extends AbstractRestController
      * Get all the balloons for this contest.
      *
      * @throws NonUniqueResultException
+     * @return Balloon[]
      */
     #[Rest\Get('')]
     #[OA\Response(

diff --git a/webapp/src/Controller/API/JudgehostController.php b/webapp/src/Controller/API/JudgehostController.php
@@ -74,6 +74,8 @@ public function __construct(
 
     /**
      * Get judgehosts.
+     *
+     * @return Judgehost[]
      */
     #[IsGranted('ROLE_JURY')]
     #[Rest\Get('')]
@@ -1636,6 +1638,7 @@ public function getJudgeTasksAction(Request $request): array
 
     /**
      * @param JudgeTask[] $judgeTasks
+     * @return JudgeTask[]
      * @throws Exception
      */
     private function serializeJudgeTasks(array $judgeTasks, Judgehost $judgehost): array

diff --git a/webapp/src/Controller/API/JudgementTypeController.php b/webapp/src/Controller/API/JudgementTypeController.php
@@ -81,6 +81,8 @@ public function singleAction(Request $request, string $id): JudgementType
     /**
      * Get the judgement types, optionally filtered on the given IDs.
      *
+     * @param string[]|null $filteredOn
+     *
      * @return JudgementType[]
      */
     protected function getJudgementTypes(array $filteredOn = null): array