Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Update exports data #2032

Merged
merged 19 commits into from
Oct 19, 2016
Merged

Update exports data #2032

merged 19 commits into from
Oct 19, 2016

Conversation

shawnbot
Copy link
Contributor

@shawnbot shawnbot commented Sep 23, 2016

Fixes #2031.

CircleCI

😎 Previews

Changes proposed in this pull request:

  • Update census exports data with 2012-2015 figures
  • Use our more "liberal" interpretation of HS6 codes to categorize oil and gas exports
  • Re-categorize mining exports except specific precious metals (iron, copper, and gold) as "non energy minerals"
  • Further refine HS6 codes
  • Double-check state figures with @mentastc
  • Update data documentation --> Update exports data documentation #2097

/cc @coreycaitlin

Copy link
Contributor

@coreycaitlin coreycaitlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we change to nonenergy (one word)? That's how we treat the term elsewhere.

@shawnbot
Copy link
Contributor Author

@coreycaitlin fixed!

@coreycaitlin
Copy link
Contributor

Note for this data: Census has slightly different numbers on their website than they have in the downloadable file.

@shawnbot
Copy link
Contributor Author

We went over some of the HS6 categorizations with @mentastc, and as a result we're going to update this again. I'm adding the [WIP] flag back and will update the description and the data documentation accordingly.

@shawnbot shawnbot changed the title Update exports data [WIP] Update exports data Sep 26, 2016
@shawnbot
Copy link
Contributor Author

@mentastc if you get a chance, can you review the preview links above (as well as any other states here) and let us know if they look right?

@gemfarmer
Copy link
Contributor

@shawnbot where does this branch stand?

@shawnbot
Copy link
Contributor Author

It looks like we were last waiting on a review from @mentastc.

@meiqimichelle
Copy link
Contributor

Chatted with Chris, we think we're good on the data front. Might be at the last check box now -- update data documentation @shawnbot @gemfarmer

@meiqimichelle
Copy link
Contributor

@coreycaitlin and I are moving the remaining documentation task to #2097 so we can get this merged and closed -- it is our last data fixit issue!!

@meiqimichelle meiqimichelle changed the title [WIP] Update exports data Update exports data Oct 19, 2016
@coreycaitlin coreycaitlin merged commit 54b2856 into dev Oct 19, 2016
@coreycaitlin coreycaitlin deleted the update-exports-data branch October 19, 2016 22:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants