Print stylesheet #1633
Print stylesheet #1633
Conversation
| @@ -0,0 +1,22 @@ | |||
| --- | |||
There was a problem hiding this comment.
Invalid CSS after "@import 'reset'": expected "{", was ";"
There was a problem hiding this comment.
This is because of Jekyll syntax.
| @@ -0,0 +1,19 @@ | |||
| .chart-item, | |||
| .row-container, | |||
| tr, | |||
There was a problem hiding this comment.
Properties should be ordered page-break-before, page-break-inside
|
Nice! What do you think about making all text black, and reducing its size a bit? |
|
I think those are reasonable suggestions. I also revisited the home page and some of the first pages that I changed and realized that the page is breaking in weird ways :( |
|
Is it easy to force charts and their headers to stay grouped, so they don't get split by page breaks? |
|
@ericronne I wasn't having an easy time of it. I'll take another stab though. It doesn't look great right now. Better than before, but not great. |
|
If it's not easy, my vote is onward to the Next Thing. |
| --- | ||
|
|
||
| // include reset | ||
| @import 'reset'; |
There was a problem hiding this comment.
Invalid CSS after "@import 'reset'": expected "{", was ";"
|
💥 . @ericronne I ended up keeping things in color because my timebox for print stylesheeting ran out :/ |
Fixes issue(s) #1509, #1390
😎 PREVIEW
To review:
Changes proposed in this pull request:
Some link (www.somelink.com)NOTE: I used the
!importantflag quite a bit. Normally I would applaud hound for catching me, but since these are supreme overrides and I don't want to mess around with finding the appropriate specificity for each instance I am trying to override,!importantis more helpful than harmful IMHO./cc @meiqimichelle @coreycaitlin