Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

National page #1580

Merged
merged 9 commits into from
Jul 8, 2016
Merged

National page #1580

merged 9 commits into from
Jul 8, 2016

Conversation

gemfarmer
Copy link
Contributor

@gemfarmer gemfarmer commented Jul 7, 2016

Fixes issue(s) #1521

😎 P R E V I E W

Changes proposed in this pull request:

  • I didn't pay a ton of attention to formatting or getting maps on the page. This is more/less a data and basic html structure dump to get the page jump-started!
  • Get content and data on to the national states page
  • all production
  • federal production
  • revenue
  • gdp
  • jobs
  • exports

@shawnbot not a blocker for this PR, but I was having so write issues for the sqlite db. I was able to reference and process data from new tables that I created (via .sql files), but was unable actually manipulate said tables from the sqlite shell because they "didn't exist"

/cc @coreycaitlin

@gemfarmer
Copy link
Contributor Author

This PR is ready for review. It shouldn't be merged until I clean up some of the files.

I still need to reference some tasks in the Makefile, but I will do that after lunch

@gemfarmer gemfarmer changed the title [WIP] National page National page Jul 8, 2016
@meiqimichelle
Copy link
Contributor

@coreycaitlin This looks like it's on what was the 'states navigation' homepage. Should we merge this there, or does it need to live somewhere else? ie, the url right now is .../states/ so we'd loose our nav page, I think. (am I interpreting that right @gemfarmer ?)

Also, I'm not sure if that was your intention with the national page content you were working with -- I vaguely remember the discussion around what was a 'nav home' and what data might look like for the national view.

@gemfarmer
Copy link
Contributor Author

@meiqimichelle yes, I have replaced that "navigation" view with the national page.

We could keep states/ as the navigation page and add a states/US/ page to handle the national page. That being said, I think I like the direction it is headed because I think people are more likely to check out the national view this way.

@coreycaitlin
Copy link
Contributor

I kind of don't want to have a separate nav vs. national page, if we can avoid it, but I may be overly optimistic there.

Long-term, I was envisioning this living at /explore/, since we'll be moving nearly all non-map sections currently listed there to the How it Works section.

@gemfarmer
Copy link
Contributor Author

@coreycaitlin do you think this is good for now then?

@meiqimichelle
Copy link
Contributor

I talked to @coreycaitlin and understand now :) Also, the map is just at the bottom of the page, and I didn't scroll that far. Let's move it back to the top when we have a sec.

@meiqimichelle meiqimichelle merged commit 811fbbd into state-pages Jul 8, 2016
@meiqimichelle meiqimichelle deleted the national-page branch July 8, 2016 22:28
This was referenced Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants