Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Explore > Revenue & Production: total row never updates #893

Closed
shawnbot opened this issue Nov 25, 2015 · 2 comments
Closed

Explore > Revenue & Production: total row never updates #893

shawnbot opened this issue Nov 25, 2015 · 2 comments
Assignees
@shawnbot

Comments

@shawnbot
Copy link
Contributor

When you visit Federal Production or Federal Revenue and change the filters, the "total" row never changes:

image

I think what needs to happen is what I fixed in GDP by calling header.append('tr').call(createRegionRow) rather than just header.call(createRegionRow), the latter of which just adds <td> elements as descendants of the <thead> so they're not selected the next time around.
@shawnbot shawnbot self-assigned this Nov 25, 2015
shawnbot pushed a commit that referenced this issue Dec 1, 2015
fix revenue for #893
a411da7
shawnbot pushed a commit that referenced this issue Dec 1, 2015
fix production for #893
1fbbf7b
@shawnbot
Copy link
Contributor Author

shawnbot commented Dec 1, 2015

These will be fixed when #945 merges.

@shawnbot
Copy link
Contributor Author

shawnbot commented Dec 7, 2015

Done!

@shawnbot shawnbot closed this as completed Dec 7, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shawnbot shawnbot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@shawnbot