Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Nationwide Coal production for 2012 looks off #1644

Closed
shawnbot opened this issue Jul 22, 2016 · 4 comments
Closed

Nationwide Coal production for 2012 looks off #1644

shawnbot opened this issue Jul 22, 2016 · 4 comments
Assignees
@shawnbot
Labels
data-mgmt Use this label for adding and/or updating data on the site. Also can be used for data management too

Comments

@shawnbot
Copy link
Contributor

shawnbot commented Jul 22, 2016 •
edited
Loading

Is it possible that there's a problem with the data from EIA? Our data tests should cover this, but it needs to be looked at, because I suspect something is wrong with our national data:

image
@shawnbot shawnbot added type:bug data-mgmt Use this label for adding and/or updating data on the site. Also can be used for data management too labels Jul 22, 2016
@shawnbot shawnbot self-assigned this Jul 22, 2016
@meiqimichelle
Copy link
Contributor

@mentastc do you know anything about this, or have any ideas?

@shawnbot
Copy link
Contributor Author

Okay, yeah. Our 2012 numbers are definitely off. Our regional (state) all production table contains the following for 2012 and 2013:

yearregionvolume
2012AK143
2013AK1631584
2012AL5041
2013AL18620017
2012AR73
2013AR58578
2012AZ432
2013AZ7602722
2012CO2505
2013CO24236286
2012IL4512
2013IL52147193
2012IN3935
2013IN39101834
2012KS6
2013KS22150
2012LA270
2013LA2809771
2012MD476
2013MD1925291
2012MO32
2013MO413703
2012MS211
2013MS3575069
2012MT1233
2013MT42231483
2012ND1228
2013ND27639060
2012NM1291
2013NM21968641
2012OH3191
2013OH25112837
2012OK199
2013OK1135797
2012TN363
2013TN1098437
2012TX2918
2013TX42850619
2012UT1611
2013UT16976724
2012VA4998
2013VA16619072
2012WY7004
2013WY387923828

I dug into the source data a bit more and discovered that the state names sometimes contain qualifiers like Kentucky (East), West Virginia (Northern) and Pennsylvania (Anthracite), but the 2012 values for these were much lower than their 2013 counterparts. I'm filing a separate PR to fix the rollups with the clean state names.

@meiqimichelle
Copy link
Contributor

Awesome, thanks for tracking that down @shawnbot

shawnbot pushed a commit that referenced this issue Jul 22, 2016
clean up state names in coal all production
592f4ac 
The source data (from EIA) for all lands coal production contains state
names like "Kentucy (Northern)" and "Pennsylvania (Anthracite)". This
change updates the transform for coal data to strip the parentheticals,
and commits the newly rendered data. I discovered this issue while
investigating #1644, but this is not a full fix.
@shawnbot shawnbot mentioned this issue Jul 22, 2016
Merged
@shawnbot
Copy link
Contributor Author

Fixed in #1645!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@shawnbot shawnbot

Labels
data-mgmt Use this label for adding and/or updating data on the site. Also can be used for data management too
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@shawnbot @meiqimichelle