Skip to content
This repository has been archived by the owner on Nov 10, 2020. It is now read-only.

Add sparklines or barchart component #1434

Closed
gemfarmer opened this issue May 25, 2016 · 9 comments
Closed

Add sparklines or barchart component #1434

gemfarmer opened this issue May 25, 2016 · 9 comments

Comments

@gemfarmer
Copy link
Contributor

gemfarmer commented May 25, 2016

Refs

Design: #1348
Code: #1431

Like this!

screen shot 2016-05-25 at 4 44 14 pm

@meiqimichelle
Copy link
Contributor

@shawnbot What's the status on this one? I know you've got a WIP on this. Can we merge it into the main state profile branch and use the spark to implement @ericronne 's design?

@shawnbot
Copy link
Contributor

shawnbot commented Jun 6, 2016

I'd love @ericronne's input on #1448, then we can close this out when it merges.

@meiqimichelle
Copy link
Contributor

@ericronne @shawnbot Did y'all chat on this? Can we merge? Thx!

@shawnbot
Copy link
Contributor

Should we turn this into the bar chart design issue?

@meiqimichelle
Copy link
Contributor

Sure! To be clear, I think you mean: turning the line charts into the latest design on the bar charts, right @shawnbot ?

@shawnbot
Copy link
Contributor

Yep, @meiqimichelle!

@ericronne
Copy link
Contributor

@shawnbot
Assuming not all bar charts will cover a tidy 10-year stretch, we need to set the design pattern for when we have various numbers of years. Here's what a seven-column chart would look like if we merely stretched it ...

image

This may not be bad (at least for now), especially if these charts with various numbers of columns don't commingle.

Also this is one way we could treat gaps in data ...
image

@shawnbot
Copy link
Contributor

Yep, good call @ericronne. The outlier here might be whichever of the all lands production commodities has data back to the 1970s, but in that case we can either constrain the year range the data side (to fit the narrowest common window), or explicitly limit all of the related bar charts to the same year range so it doesn't look weird (and so that it's less confusing). cc @meiqimichelle

@usEITI
Copy link

usEITI commented Jun 30, 2016

👍

On Wed, Jun 29, 2016 at 2:07 PM, Eric Ronne [email protected]
wrote:

@shawnbot https://github.com/shawnbot
Assuming not all bar charts will cover a tidy 10-year stretch, we need to
set the design pattern for when we have various numbers of years. Here's
what a seven-column chart would look like if we merely stretched it ...

[image: image]
https://cloud.githubusercontent.com/assets/9259185/16463160/1eedc3b0-3dfa-11e6-879a-a8f8c02e885c.png

This may not be bad (at least for now), especially if these charts with
various numbers of columns don't commingle.

Also this is one way we could treat gaps in data ...
[image: image]
https://cloud.githubusercontent.com/assets/9259185/16463200/606591b0-3dfa-11e6-9d43-e4083e2d2797.png


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#1434 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ANnOZLd3mIJrA1UMyw7M0hYdmCBbWBjWks5qQrRLgaJpZM4InABR
.

Judy Wilson
Program Manager USEITI Secretariat *
*Office of Natural Resources Revenue

[email protected] [email protected]
202-208-4410

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants