Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix eb environment ignore changes #33

Merged
merged 1 commit into from
Jun 27, 2023
Merged

Fix eb environment ignore changes #33

merged 1 commit into from
Jun 27, 2023

Conversation

caiovfernandes
Copy link
Contributor

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • I have read the CONTRIBUTING.md doc.
  • I have added necessary documentation (if appropriate).
  • Any dependent changes have been merged and published in downstream modules. off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@caiovfernandes caiovfernandes self-assigned this Jun 27, 2023
luizfds
luizfds approved these changes Jun 27, 2023
View reviewed changes
Copy link
Contributor

@luizfds luizfds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caiovfernandes caiovfernandes merged commit 0af93ed into master Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luizfds luizfds luizfds approved these changes

@mcosta1105 mcosta1105 Awaiting requested review from mcosta1105

Assignees

@caiovfernandes caiovfernandes

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caiovfernandes @luizfds