Skip to content

Commit

Permalink
Merge pull request #32 from DNXLabs/improvement/environment_dns_ignor…
Browse files Browse the repository at this point in the history
…e_changes

Improvement/environment dns ignore changes
  • Loading branch information
caiovfernandes authored Jun 5, 2023
2 parents c80db67 + 7d24816 commit f4d0458
Show file tree
Hide file tree
Showing 6 changed files with 20 additions and 4 deletions.
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
.DS_Store
.DS_Store
.idea/vcs.xml
.idea/modules.xml
5 changes: 5 additions & 0 deletions .idea/.gitignore

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 2 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ The following resources will be created:
| eb\_platform | Platform type, e.g. 'dotnet', 'dotnetcorelinux' | `string` | `"dotnet"` | no |
| eb\_solution\_stack\_name | Stack name passed to ElasticBeanstalk | `any` | n/a | yes |
| eb\_tier | Elastic Beanstalk Environment tier, 'WebServer' or 'Worker' | `string` | `"WebServer"` | no |
| eb\_version\_label | Elastic Beanstalk Application version to deploy | `string` | `""` | no |
| eb\_version\_label | Elastic Beanstalk Application version to deploy | `string` | `"latest"` | no |
| eb\_wait\_for\_ready\_timeout | The maximum duration to wait for the Elastic Beanstalk Environment to be in a ready state before timing out | `string` | `"20m"` | no |
| egress\_rules | How long to wait for the security group to be created. | <pre>list(object({<br> from_port = string<br> to_port = string<br> protocol = string<br> description = string<br> cidr_blocks = list(string)<br> security_groups = list(string)<br> self = string<br> }))</pre> | `[]` | no |
| elb\_scheme | Specify `internal` if you want to create an internal load balancer in your Amazon VPC so that your Elastic Beanstalk application cannot be accessed from outside your Amazon VPC | `string` | `"public"` | no |
Expand Down Expand Up @@ -105,6 +105,7 @@ The following resources will be created:
| key\_name | Defines a SSH keypair to access EB instances (leave empty to create one) | `string` | `""` | no |
| loadbalancer\_access\_logs\_s3\_enabled | Enable or disable logs on load balancer | `bool` | `false` | no |
| loadbalancer\_certificate\_arn | Load Balancer SSL certificate ARN. The certificate must be present in AWS Certificate Manager | `string` | `""` | no |
| loadbalancer\_idle\_timeout | Load balancer connection idle timeout | `number` | `60` | no |
| loadbalancer\_is\_shared | Flag to create a shared application loadbalancer. Only when loadbalancer\_type = "application" https://docs.aws.amazon.com/elasticbeanstalk/latest/dg/environments-cfg-alb-shared.html | `bool` | `false` | no |
| loadbalancer\_managed\_security\_group | Load balancer managed security group | `string` | `""` | no |
| loadbalancer\_security\_groups | Load balancer security groups | `list(string)` | `[]` | no |
Expand Down
2 changes: 1 addition & 1 deletion _variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ variable "eb_tier" {

variable "eb_version_label" {
type = string
default = ""
default = "latest"
description = "Elastic Beanstalk Application version to deploy"
}

Expand Down
4 changes: 4 additions & 0 deletions alb-rule-redirect.tf
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,8 @@ resource "aws_lb_listener_rule" "redirect_http_to_https" {
values = ["/*"]
}
}

lifecycle {
ignore_changes = [listener_arn]
}
}
6 changes: 5 additions & 1 deletion eb.tf
Original file line number Diff line number Diff line change
Expand Up @@ -709,11 +709,15 @@ resource "aws_elastic_beanstalk_environment" "env" {
resource = ""
}
}

lifecycle {
ignore_changes = [cname_prefix]
}
}

data "aws_elastic_beanstalk_solution_stack" "solution_stack" {
count = length(var.solutions_stack_name_regex) > 0 ? 1 : 0
most_recent = true

name_regex = var.solutions_stack_name_regex
name_regex = var.solutions_stack_name_regex
}

0 comments on commit f4d0458

Please sign in to comment.