Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX: move subscriptions when moving topic #538

Merged
merged 2 commits into from
Oct 5, 2023
Merged

FIX: move subscriptions when moving topic #538

merged 2 commits into from
Oct 5, 2023

Conversation

johnhenley
Copy link
Collaborator

Description of PR...

Topic subscriptions should be moved with topic.

Changes made

  • change stored procedure activeforums_Topics_Move to move subscriptions when moving topic
  • change stored procedure activeforums_Subscriptions_IsSubscribed to look at subscription based on topic without regard to forum (for backward compatibility)

How did you test these updates?

  1. subscrbed to topic
    image

  2. moved topic
    image

  3. subscription stayed
    image

PR Template Checklist

  • Fixes Bug
  • Feature solution
  • Other
  • Requires documentation updates
  • I've updated the documentation already

Please mark which issue is solved

Close #537

@johnhenley johnhenley added the bug Something isn't working label Oct 5, 2023
@johnhenley johnhenley added this to the 08.00.00 milestone Oct 5, 2023
@johnhenley johnhenley requested a review from WillStrohl October 5, 2023 15:26
@johnhenley johnhenley self-assigned this Oct 5, 2023
@WillStrohl
Copy link
Member

@johnhenley We got a SQL conflict. I'm guessing you are SO surprised. 😆

WillStrohl
WillStrohl approved these changes Oct 5, 2023
View reviewed changes
Copy link
Member

@WillStrohl WillStrohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@WillStrohl WillStrohl merged commit d32ecf4 into DNNCommunity:dev Oct 5, 2023
@johnhenley
Copy link
Collaborator Author

johnhenley commented Oct 5, 2023 •
edited
Loading

@johnhenley We got a SQL conflict. I'm guessing you are SO surprised. 😆

Yes as expected. But at least I've figured out how to resolve it quickly

@johnhenley johnhenley deleted the issues/537-move-topic-move-subscription branch October 5, 2023 15:38
@johnhenley johnhenley restored the issues/537-move-topic-move-subscription branch October 5, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WillStrohl WillStrohl WillStrohl approved these changes

Assignees

@johnhenley johnhenley

Labels
bug Something isn't working
Projects
None yet
Milestone
08.00.00
Development

Successfully merging this pull request may close these issues.

BUG: Move topic needs to move subscriptions
2 participants
@johnhenley @WillStrohl