Add eddsa fips #1803
Merged
Add eddsa fips #1803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wenxing-hou
force-pushed
the
Add_eddsa_fips
branch
2 times, most recently
from
e54a57c
to
32343a2
Compare
jyao1
reviewed
Mar 17, 2023
Wenxing-hou
force-pushed
the
Add_eddsa_fips
branch
2 times, most recently
from
48a9bf7
to
76dd278
Compare
jyao1
approved these changes
Mar 23, 2023
steven-bellock
requested changes
Mar 24, 2023
| **/ | ||
|
|
||
| #include "internal/libspdm_crypt_lib.h" | ||
| #include "spdm_crypt_ext_lib/cryptlib_ext.h" |
There was a problem hiding this comment.
This path should be in hal/library/cryptlib since it's needed by one of the core libraries.
There was a problem hiding this comment.
Thanks. I have changed the code.
Fix the issue: DMTF#1738 Signed-off-by: Wenxing Hou <[email protected]>
Fix the issue: DMTF#1738 Signed-off-by: Wenxing Hou <[email protected]>
Wenxing-hou
force-pushed
the
Add_eddsa_fips
branch
from
76dd278
to
b20423c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1738
Signed-off-by: Wenxing Hou [email protected]