Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use current user rather than form user id which can be spoofed #3077

Merged
merged 1 commit into from
Dec 9, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/controllers/notes_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ class NotesController < ApplicationController
# rubocop:disable Metrics/AbcSize, Metrics/MethodLength
def create
@note = Note.new
@note.user_id = note_params[:user_id]
# take user id from current user rather than form as form can be spoofed
@note.user_id = current_user.id
# ensure user has access to plan BEFORE creating/finding answer
unless Plan.find_by(id: note_params[:plan_id]).readable_by?(@note.user_id)
raise Pundit::NotAuthorizedError
Expand Down