Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide locked word on submissions list for small-width screens #1430

Merged
merged 2 commits into from
Jun 5, 2020

Conversation

Ninjaclasher
Copy link
Member

No description provided.

Copy link
Member

@quantum5 quantum5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but greying out the icon would be a nice bonus.

@codecov-commenter
Copy link

codecov-commenter commented Jun 5, 2020

Codecov Report

Merging #1430 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1430   +/-   ##
=======================================
  Coverage   38.44%   38.44%           
=======================================
  Files         201      201           
  Lines       11398    11398           
=======================================
  Hits         4382     4382           
  Misses       7016     7016           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66403cc...ab97efd. Read the comment docs.

@Ninjaclasher
Copy link
Member Author

Looks fine, but greying out the icon would be a nice bonus.

The current icon is black. Should the black be changed to grey?

E.g.
image

@quantum5
Copy link
Member

quantum5 commented Jun 5, 2020

Yes, that would be a nice change.

@Ninjaclasher
Copy link
Member Author

Done

@quantum5 quantum5 merged commit 8b32be7 into DMOJ:master Jun 5, 2020
@Ninjaclasher Ninjaclasher deleted the hide-locked branch June 5, 2020 22:03
ehhthing pushed a commit to mcpt/wlmoj that referenced this pull request Jun 6, 2020
outloudvi pushed a commit to SchOJ/site that referenced this pull request Oct 27, 2020
malbareda pushed a commit to malbareda/JOEL-web that referenced this pull request Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants