Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executors: use shutil.which instead of deprecated distutils #949

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

quantum5
Copy link
Member

@quantum5 quantum5 commented Sep 22, 2021

See PEP 632, which suggests replacing distutils.spawn.find_executable with shutil.which.

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #949 (04bc78c) into master (9704d41) will decrease coverage by 0.10%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #949      +/-   ##
==========================================
- Coverage   86.54%   86.44%   -0.11%     
==========================================
  Files         138      138              
  Lines        4736     4735       -1     
==========================================
- Hits         4099     4093       -6     
- Misses        637      642       +5     
Impacted Files Coverage Δ
dmoj/executors/shell_executor.py 0.00% <0.00%> (ø)
dmoj/executors/base_executor.py 85.37% <100.00%> (-0.05%) ⬇️
dmoj/cptbox/tracer.py 83.27% <0.00%> (-1.82%) ⬇️
dmoj/result.py 89.33% <0.00%> (-1.34%) ⬇️
dmoj/graders/interactive.py 73.86% <0.00%> (+1.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9704d41...04bc78c. Read the comment docs.

See PEP 632, which suggests replacing distutils.spawn.find_executable with shutil.which.
@quantum5
Copy link
Member Author

retest this please

Copy link
Member

@Xyene Xyene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xyene Xyene merged commit 93ef162 into master Sep 23, 2021
@Xyene Xyene deleted the shutil-which branch September 23, 2021 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants