Kill the judging submission first with a keyboard interrupt on CLI #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #700 +/- ##
=======================================
Coverage 84.68% 84.68%
=======================================
Files 125 125
Lines 4205 4205
=======================================
Hits 3561 3561
Misses 644 644 Continue to review full report at Codecov.
|
Ninjaclasher
force-pushed
the
cmdline-submit-abort
branch
from
0c6832f to
032d13f
Compare
quantum5
approved these changes
Jun 13, 2020
|
On that note should also make |
Xyene
approved these changes
Jun 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more of a QOL improvement. Currently, when there is a long running submission (e.g a submission that TLEs on every case), there is no way to abort the submission. Pressing
Ctrl-Cwould kill the CLI, potentially losing any commands that were previously typed and had scrolled off the screen (since there is no persistent history). Thus, the only way would be to wait out the grading.In this PR, instead of killing the CLI directly while a submission is grading, we first kill the currently grading submission if there is one.