You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
GitHub/GitLab detection is really naiive. It only tests for occurence of "github" or "gitlab" strings in the given extraction url. GitLab projects can be called r'.*github.*' which would lead gitlab2prov to try to use the GitHub API for a project hosted on gitlab.
Describe the solution you'd like
Users should be able to declare which platform the project is hosted on by declaring a command line flag/argument such as --platform for the extraction subcommand. Additionally we should think about making a test request to the project url to find out whether its hosted on gitlab or github.
Command line flag
HTTP request to find automatically resolve the platform
The text was updated successfully, but these errors were encountered:
Maybe it would be better to split gitlab2prov & github2prov into two seperate cli tools. E.g.
github2prov
and
gitlab2prov
they could share commands like load, save, combine, etc. and have their own subset of commands with gitlab/github specific behaviour such as merge-duplicated-agents etc.
@click.group()defgitlab2prov():
pass@click.group()defgithub2prov():
pass@click.command()defexample():
pass# add gitlab specific cmdsgitlab2prov.add_command(example)
gitlab2prov.add_command(example)
# add github specific cmdsgithub2prov.add_command(example)
github2prov.add_command(example)
Note: If you split github & gitlab behaviour into seperate cli's you can't use a single config file containing github & gitlab urls. This should be noted in the README
Is your feature request related to a problem? Please describe.
GitHub/GitLab detection is really naiive. It only tests for occurence of "github" or "gitlab" strings in the given extraction url. GitLab projects can be called
r'.*github.*'
which would lead gitlab2prov to try to use the GitHub API for a project hosted on gitlab.Describe the solution you'd like
Users should be able to declare which platform the project is hosted on by declaring a command line flag/argument such as
--platform
for the extraction subcommand. Additionally we should think about making a test request to the project url to find out whether its hosted on gitlab or github.The text was updated successfully, but these errors were encountered: